Skip to content

feat: add releaseEventOnEdges for wheel #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: add releaseEventOnEdges for wheel #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/CameraControls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,13 @@ export class CameraControls extends EventDispatcher {
*/
touches: Touches;

/**
* Disable internal preventDefault if the user's gesture reached the limits of the camera move.
* Currently only works for wheel events.
* @category Properties
*/
releaseEventOnEdges: boolean = false;

/**
* Force cancel user dragging.
* @category Methods
Expand Down Expand Up @@ -863,8 +870,6 @@ export class CameraControls extends EventDispatcher {

}

event.preventDefault();

if (
this.dollyToCursor ||
this.mouseButtons.wheel === ACTION.ROTATE ||
Expand All @@ -884,6 +889,7 @@ export class CameraControls extends EventDispatcher {
const delta = ( event.deltaMode === 1 ) ? event.deltaY / deltaYFactor : event.deltaY / ( deltaYFactor * 10 );
const x = this.dollyToCursor ? ( event.clientX - this._elementRect.x ) / this._elementRect.width * 2 - 1 : 0;
const y = this.dollyToCursor ? ( event.clientY - this._elementRect.y ) / this._elementRect.height * - 2 + 1 : 0;
let preventDefault = true;

switch ( this.mouseButtons.wheel ) {

Expand Down Expand Up @@ -915,6 +921,10 @@ export class CameraControls extends EventDispatcher {

this._dollyInternal( - delta, x, y );
this._isUserControllingDolly = true;

if ( this.releaseEventOnEdges && delta > 0 && approxEquals( this.minDistance, this._sphericalEnd.radius ) ) preventDefault = false;
if ( this.releaseEventOnEdges && delta < 0 && approxEquals( this.maxDistance, this._sphericalEnd.radius ) ) preventDefault = false;

break;

}
Expand All @@ -923,12 +933,17 @@ export class CameraControls extends EventDispatcher {

this._zoomInternal( - delta, x, y );
this._isUserControllingZoom = true;

if ( this.releaseEventOnEdges && delta > 0 && approxEquals( this.minZoom, this._zoom ) ) preventDefault = false;
if ( this.releaseEventOnEdges && delta < 0 && approxEquals( this.maxZoom, this._zoom ) ) preventDefault = false;

break;

}

}

preventDefault && event.preventDefault();
this.dispatchEvent( { type: 'control' } );

};
Expand Down