fix: incorrect camera direction on boundary zoom #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Fixed an issue where the camera's lookat direction would be incorrect when zooming to the extreme position of the viewing angle with the mouse after setting boundary and boundaryEncloseSComera to true, resulting in errors in the subsequent updates of the camera's cropping and causing some related calculation errors
|
Thank you for the PR! |
yomotsu
changed the title
yomotsu
force-pushed
the
dev
branch
4 times, most recently
from
9f1d761 to
38c26ca
Compare
|
maybe writing a repro test could also help here (once #592 is merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fixed an issue where when setting boundary and boundaryEncloseSComera to true, zooming back to the extreme position of the viewpoint with the mouse would result in incorrect looking direction of the camera, leading to errors in subsequent updates of the camera's cropping plane and causing some related calculation errors