Closed
Conversation
abernier
commented
Jul 28, 2025
Comment on lines
+2947
to
+2948
| this.rotateTo( obj.spherical[ 2 ], obj.spherical[ 1 ], enableTransition ); | ||
| this.dollyTo( obj.spherical[ 0 ], enableTransition ); |
Collaborator
Author
There was a problem hiding this comment.
reuse obj.spherical directly
abernier
commented
Jul 28, 2025
|
|
||
| target : this._targetEnd.toArray(), | ||
| position : _v3A.setFromSpherical( this._sphericalEnd ).add( this._targetEnd ).toArray(), | ||
| spherical : [ this._sphericalEnd.radius, this._sphericalEnd.phi, this._sphericalEnd.theta ], |
Collaborator
Author
There was a problem hiding this comment.
export spherical property
abernier
commented
Jul 28, 2025
| position: [number, number, number] | ||
| } ); | ||
|
|
||
| export type CameraControlsState = { |
Collaborator
Author
There was a problem hiding this comment.
a type for the state
abernier
commented
Jul 28, 2025
Collaborator
Author
abernier
left a comment
abernier
left a comment
There was a problem hiding this comment.
I've added a spherical property to the exported .toSON() and consume it inside .fromJSON()
Collaborator
Author
|
maybe adding a test could be good, to test once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.