Handle membership exceptions for synchronized root groups

[mirkokg]

Adds logic to detect and register membership exceptions for PBXFileSystemSynchronizedRootGroup objects, specifically excluding Info.plist files from group membership when necessary. Also ensures resources build phase is added if synchronized root groups are present.

I noticed that current implementation of synchronizedGroups does not ignore Info.plist.
I inspected default Xcode behavior and noticed that when you create new Xcode project you get empty copy Resources section:

/* Begin PBXResourcesBuildPhase section */
		232C80EF2ECFA3E300DF1D84 /* Resources */ = {
			isa = PBXResourcesBuildPhase;
			buildActionMask = 2147483647;
			files = (
			);
			runOnlyForDeploymentPostprocessing = 0;
		};
/* End PBXResourcesBuildPhase section */

If this empty PBXResourcesBuildPhase is not present xcassets will not be copied automatically for syncedFolder.

I also noticed that by default it adds Info.plist to ignore list as PBXFileSystemSynchronizedBuildFileExceptionSet:

/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
		232C81032ECFA3E400DF1D84 /* Exceptions for "tester" folder in "tester" target */ = {
			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
			membershipExceptions = (
				Info.plist,
			);
			target = 232C80F02ECFA3E300DF1D84 /* tester */;
		};
/* End PBXFileSystemSynchronizedBuildFileExceptionSet section */

There are three functionalities implemented with this patch:

• Allows you to add excludes for syncedFolder
• Adds exclude for Info.plist if its within the syncedFolder
• Adds empty copy resources build phase for resources to be copied

This patch fixes an issue with synchronized folders reported by @KieranHarper :

#1586

[mirkokg]

I also created a PR to fix TEMP_ prefixes for PBXFileSystemSynchronizedBuildFileExceptionSet tuist/XcodeProj#1014 in Xcodeproj, but besides cosmetic problem this issue does not affect XcodeGen negatively.

[mirkokg]

@yonaskolb please review and let me know if you would change anything. I tested with my projects and all worked perfectly with my version.

[mirkokg]

@yonaskolb my PR for TEMP_ prefixes is merged now in XcodeProj, can you help with merging this?

[hiragram]

@mirkokg @yonaskolb Any update on this?

[mirkokg]

@hiragram to be honest, I have no idea why is it taking so long.
This is my first PR on the project, and I received no feedback. I would do anything I can to merge it ASAP :-(
My XcodeProj PR tuist/XcodeProj#1014 was merged relatively quickly.
@yonaskolb any chance to review this as well?

[yonaskolb]

Hi @mirkokg, thank you for the changes, they look good.
To get this in, could you add some tests around those 3 new capabilities. That means 3 focused unit tests, and some additions to the TestProject fixture that includes all the capabilities. I'll look at the test failures we currently have.

Also currently excludes supports globs. In order to keep the same semantics, we should probably support them here, in that the globs are expanded before applying the membership exceptions. Thoughts?