-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EditReverse operation to support undo and redo on Text.edit #649
Draft
hyemmie
wants to merge
63
commits into
main
Choose a base branch
from
feat/text-edit-reverse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yourim Cha <[email protected]>
Co-authored-by: Yourim Cha <[email protected]>
Co-authored-by: Yourim Cha <[email protected]>
…yorkie-js-sdk into feat/undo-redo-arch
…yorkie-js-sdk into feat/undo-redo-arch
…nto feat/undo-redo-arch
…yorkie-js-sdk into feat/undo-redo-arch
…yorkie-js-sdk into feat/text-edit-reverse
- added message to the presence-changed event
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 89.16% 86.27% -2.89%
==========================================
Files 79 80 +1
Lines 9318 9732 +414
Branches 856 882 +26
==========================================
+ Hits 8308 8396 +88
- Misses 697 1013 +316
- Partials 313 323 +10
☔ View full report in Codecov by Sentry. |
chacha912
force-pushed
the
feat/text-edit-reverse
branch
from
September 25, 2023 08:54
c987984
to
5f9263f
Compare
hackerwins
force-pushed
the
main
branch
2 times, most recently
from
October 20, 2023 07:46
a9325d6
to
7baa69f
Compare
20 tasks
hackerwins
force-pushed
the
main
branch
6 times, most recently
from
November 25, 2023 14:15
5d46577
to
0e34144
Compare
hackerwins
force-pushed
the
main
branch
2 times, most recently
from
May 10, 2024 00:21
7dba6db
to
f765d1c
Compare
hackerwins
force-pushed
the
main
branch
5 times, most recently
from
August 16, 2024 04:24
ad3b86a
to
2f1cd8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR reflects the changes to implement undo & redo in text.edit.
The previous method, implemented in
feat/undo-redo-arch
focused on local index to create anEditReverse
. However, this method has several side effects, so I changed it to generate anEditReverse
based on the global NodeID.Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist