Skip to content

chore: Release 1.3.3 #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

chore: Release 1.3.3 #953

merged 2 commits into from
Jul 24, 2025

Conversation

lazysegtree
Copy link
Collaborator

@lazysegtree lazysegtree commented Jul 21, 2025

Summary by CodeRabbit

  • New Features
    • Updated to version 1.3.3, introducing metadata loading using an improved method for enhanced performance.
  • Bug Fixes
    • Resolved Windows test CI issues.
    • Fixed issues with the configuration file.
  • Chores
    • Updated documentation and install scripts to reference version 1.3.3.
    • Miscellaneous updates to dependency lock files.

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

The changes update the version of the "superfile" package from 1.3.2 to 1.3.3 across build configurations, installation scripts, a Go constant, and documentation. Additionally, a stray character is removed from a release script, and a new changelog entry for version 1.3.3 is added.

Changes

Files Change Summary
flake.nix, src/config/fixed_variable.go Bumped "superfile" version from 1.3.2 to 1.3.3 in build config and Go constant.
release/release.sh Updated version variable to 1.3.3 and removed stray character after loop.
website/public/install.ps1, website/public/install.sh Updated default install version to 1.3.3 in installation scripts.
website/src/content/docs/changelog.md Added changelog entry for version 1.3.3 with feature and bug fix descriptions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Installer Script
    participant Download Server

    User->>Installer Script: Run install.sh/install.ps1
    Installer Script->>Installer Script: Set version = 1.3.3 (default)
    Installer Script->>Download Server: Download superfile v1.3.3
    Download Server-->>Installer Script: Return binary
    Installer Script->>User: Install complete
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • yorukot

Poem

A hop, a skip, a version jump,
From 1.3.2 to .3 with a thump!
Changelogs updated, scripts in sync,
No more stray "w"—gone in a blink.
The bunnies rejoice, the code is neat,
Another release—oh, what a treat! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 1.3.3-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (4)
release/release.sh (1)

4-4: Minor nit: quote variable expansion for robustness
When this script is invoked with an overridden $version, a value such as v1.3.3-beta containing spaces would break. Use quotes:

-version="v1.3.3"
+version="v1.3.3"

and later: "$projectName-$os-$version-$arch", etc.

website/src/content/docs/changelog.md (3)

20-23: Standardize “Bug fix” heading and bullet capitalization

Previous releases use the lowercase “fix” (e.g., “#### Bug fix”), and bullet texts follow sentence-case (“Windows test CI”). Aligning keeps the changelog visually consistent.

-#### Bug Fix
+#### Bug fix
-
-- fix: windows test ci by [`#941`](https://github.com/yorukot/superfile/pull/941)
-- fix: fixing `config.toml` by [`#952`](https://github.com/yorukot/superfile/pull/952)
+- fix: Windows test CI [`#941`](https://github.com/yorukot/superfile/pull/941)
+- fix: incorrect `config.toml` [`#952`](https://github.com/yorukot/superfile/pull/952)

18-18: Minor grammar tweak in update bullet

“removed usage channels” reads awkwardly.

-- feat: Metadata loading via bubbletea's tea.Cmd method, removed usage channels and custom goroutines by [`#947`](https://github.com/yorukot/superfile/pull/947)
+- feat: Metadata loading via Bubbletea’s `tea.Cmd`; removed channels and custom goroutines [`#947`](https://github.com/yorukot/superfile/pull/947)

24-25: Fix typo in file name

pnpm-lcok.yamlpnpm-lock.yaml.

-- chore: update pnpm-lcok.yaml by [`#937`](https://github.com/yorukot/superfile/pull/937)
+- chore: update pnpm-lock.yaml [`#937`](https://github.com/yorukot/superfile/pull/937)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29dc4d0 and 4109451.

📒 Files selected for processing (6)
  • flake.nix (1 hunks)
  • release/release.sh (2 hunks)
  • src/config/fixed_variable.go (1 hunks)
  • website/public/install.ps1 (1 hunks)
  • website/public/install.sh (1 hunks)
  • website/src/content/docs/changelog.md (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: lazysegtree
PR: yorukot/superfile#935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.
Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.
Learnt from: lazysegtree
PR: yorukot/superfile#752
File: src/internal/common/load_config.go:27-37
Timestamp: 2025-04-03T16:05:49.630Z
Learning: In the superfile project, configuration struct fields use PascalCase (e.g., "ShellCloseOnSuccess") while their corresponding TOML field names use snake_case (e.g., "shell_close_on_success") as defined in the struct tags. Boolean configuration fields typically don't require explicit validation in the LoadConfigFile function, unlike numeric fields which have range validations.
Learnt from: lazysegtree
PR: yorukot/superfile#906
File: src/internal/file_panel.go:11-14
Timestamp: 2025-07-12T05:32:53.131Z
Learning: lazysegtree is concerned about the efficiency impact of adding bounds checking to frequently called methods like getSelectedItem() in file panels, preferring to defer such changes to consider performance implications.
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/ui/sidebar/render.go:46-48
Timestamp: 2025-04-28T03:48:46.327Z
Learning: The user (lazysegtree) prefers to keep PRs focused and manageable in size, sometimes intentionally leaving TODO comments to track minor issues for later PRs rather than addressing everything at once.
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/model_render.go:254-256
Timestamp: 2025-04-28T04:27:33.074Z
Learning: When race conditions or other issues that are unrelated to the current PR's focus are identified during review, lazysegtree prefers creating separate GitHub issues to track them rather than addressing them in the current PR. This helps maintain PR focus and scope.
Learnt from: lazysegtree
PR: yorukot/superfile#775
File: src/internal/common/style_function.go:240-243
Timestamp: 2025-04-27T17:04:47.888Z
Learning: lazysegtree plans to refactor textinput.Model creation in the future to fix the code duplication issue that caused a bug where the sidebar search model was created without setting the Width property.
flake.nix (1)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

website/public/install.ps1 (1)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

website/src/content/docs/changelog.md (2)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.

website/public/install.sh (2)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.

🪛 markdownlint-cli2 (0.17.2)
website/src/content/docs/changelog.md

17-17: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4

(MD001, heading-increment)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: greet
  • GitHub Check: Build and Test (windows-latest)
  • GitHub Check: Analyze (go)
🔇 Additional comments (4)
flake.nix (1)

30-30: Version bump looks correct & consistent
No issues spotted with the simple 1.3.3 update.

src/config/fixed_variable.go (1)

14-14: Constant updated – double-check tag prefix conventions
CurrentVersion keeps the leading v, while other scripts pass the raw number and manually prepend v later. That asymmetry is harmless internally but occasionally confuses tooling. Verify that any code comparing raw version strings normalises them first.

release/release.sh (1)

29-29: 👍 Stray character removed, loop now terminates cleanly
No further action needed.

website/src/content/docs/changelog.md (1)

13-17: Heading format matches project convention — keep as is

The # / #### pattern is consistent with earlier entries and the maintainer’s stated preference; no action needed despite markdown-lint warning.

@lazysegtree lazysegtree marked this pull request as draft July 22, 2025 06:49
@lazysegtree
Copy link
Collaborator Author

lazysegtree commented Jul 22, 2025

Need to finish up metadata separation PR before this, add unit tests, etc, and do more testing. Better than releasing with a half baked changes.

Depends on PR

@lazysegtree lazysegtree marked this pull request as ready for review July 24, 2025 03:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
website/src/content/docs/changelog.md (5)

19-19: Fix link-bracket formatting and wording

Missing space before the PR reference and a bare URL break the established changelog style.

- - feat: Metadata panel into separate package, UI bug fixes, Code improvements[`#950`] (https://github.com/yorukot/superfile/pull/950)
+ - feat: Migrate metadata panel into a separate package, apply UI bug fixes, and perform code improvements by [`#950`](https://github.com/yorukot/superfile/pull/950)

21-21: Align subsection title with existing convention

Previous releases use “Bug fix”. Keep the casing consistent.

-#### Bug Fix
+#### Bug fix

26-26: Typo: pnpm-lcok.yamlpnpm-lock.yaml

Spelling slip in the filename.

- - chore: update pnpm-lcok.yaml by [`#937`](https://github.com/yorukot/superfile/pull/937)
+ - chore: update pnpm-lock.yaml by [`#937`](https://github.com/yorukot/superfile/pull/937)

27-27: Correct link formatting and slight wording tweak

Same space / bare-URL issue as above.

- - feat: add support for Python virtual environment in testsuite setup[`#956`] (https://github.com/yorukot/superfile/pull/956)
+ - feat: add support for Python virtual environments in testsuite setup by [`#956`](https://github.com/yorukot/superfile/pull/956)

18-18: Minor grammar improvement (optional)

“Removed usage channels” reads awkwardly. Consider rephrasing.

- - feat: Metadata loading via bubbletea's tea.Cmd method, removed usage channels and custom goroutines by [`#947`](https://github.com/yorukot/superfile/pull/947)
+ - feat: Metadata loading via Bubbletea's `tea.Cmd`; removed channels and custom goroutines by [`#947`](https://github.com/yorukot/superfile/pull/947)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4109451 and ad0e88a.

📒 Files selected for processing (1)
  • website/src/content/docs/changelog.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/ui/sidebar/render.go:46-48
Timestamp: 2025-04-28T03:48:46.327Z
Learning: The user (lazysegtree) prefers to keep PRs focused and manageable in size, sometimes intentionally leaving TODO comments to track minor issues for later PRs rather than addressing everything at once.
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/model_render.go:254-256
Timestamp: 2025-04-28T04:27:33.074Z
Learning: When race conditions or other issues that are unrelated to the current PR's focus are identified during review, lazysegtree prefers creating separate GitHub issues to track them rather than addressing them in the current PR. This helps maintain PR focus and scope.
Learnt from: lazysegtree
PR: yorukot/superfile#935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.
Learnt from: lazysegtree
PR: yorukot/superfile#953
File: website/public/install.sh:42-42
Timestamp: 2025-07-21T08:49:44.603Z
Learning: In the superfile bash installer (website/public/install.sh), lazysegtree maintains the same principle as the PowerShell installer - users should supply correct environment variable values (SPF_INSTALL_VERSION without leading 'v') rather than adding validation code to handle malformed input, following the philosophy that users should provide properly formatted values.
Learnt from: lazysegtree
PR: yorukot/superfile#752
File: src/internal/common/load_config.go:27-37
Timestamp: 2025-04-03T16:05:49.630Z
Learning: In the superfile project, configuration struct fields use PascalCase (e.g., "ShellCloseOnSuccess") while their corresponding TOML field names use snake_case (e.g., "shell_close_on_success") as defined in the struct tags. Boolean configuration fields typically don't require explicit validation in the LoadConfigFile function, unlike numeric fields which have range validations.
Learnt from: lazysegtree
PR: yorukot/superfile#953
File: website/public/install.ps1:25-25
Timestamp: 2025-07-21T08:49:13.041Z
Learning: In the superfile PowerShell installer (website/public/install.ps1), lazysegtree prefers that users supply correct environment variable values (like SPF_INSTALL_VERSION without leading 'v') rather than adding validation code to handle malformed input, following the principle that users should provide properly formatted values.
Learnt from: lazysegtree
PR: yorukot/superfile#906
File: src/internal/file_panel.go:11-14
Timestamp: 2025-07-12T05:32:53.131Z
Learning: lazysegtree is concerned about the efficiency impact of adding bounds checking to frequently called methods like getSelectedItem() in file panels, preferring to defer such changes to consider performance implications.
Learnt from: lazysegtree
PR: yorukot/superfile#775
File: src/internal/common/style_function.go:240-243
Timestamp: 2025-04-27T17:04:47.888Z
Learning: lazysegtree plans to refactor textinput.Model creation in the future to fix the code duplication issue that caused a bug where the sidebar search model was created without setting the Width property.
website/src/content/docs/changelog.md (3)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:25:06.352Z
Learning: PR #770 "Sidebar code separation" is a refactoring and code reorganization effort with no new features. It involves moving code, updating import paths, renaming functions to follow PascalCase convention, and consolidating sidebar-related functionality into a dedicated package.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.

🪛 markdownlint-cli2 (0.17.2)
website/src/content/docs/changelog.md

17-17: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4

(MD001, heading-increment)


19-19: Bare URL used

(MD034, no-bare-urls)


27-27: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and Test (windows-latest)
  • GitHub Check: Analyze (go)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
website/src/content/docs/changelog.md (2)

18-20: Fix grammar / spacing in “Update” bullets

Minor wording tweaks and a missing space in the PR reference:

- - feat: Metadata loading via bubbletea's tea.Cmd method, removed usage channels and custom goroutines by [`#947`](https://github.com/yorukot/superfile/pull/947)
- - feat: Metadata panel into separate package, UI bug fixes, Code improvements[`#950`](https://github.com/yorukot/superfile/pull/950)
+ - feat: Metadata loading via bubbletea’s `tea.Cmd` method, removed usage **of** channels and custom goroutines [`#947`](https://github.com/yorukot/superfile/pull/947)
+ - feat: Move metadata panel into a separate package; UI bug fixes and code improvements [`#950`](https://github.com/yorukot/superfile/pull/950)

26-27: Correct typo and add missing spaces

- - chore: update pnpm-lcok.yaml by [`#937`](https://github.com/yorukot/superfile/pull/937)
- - feat: add support for Python virtual environment in testsuite setup[`#956`](https://github.com/yorukot/superfile/pull/956)
+ - chore: update pnpm-lock.yaml [`#937`](https://github.com/yorukot/superfile/pull/937)
+ - feat: add support for Python virtual environment in testsuite setup [`#956`](https://github.com/yorukot/superfile/pull/956)

Fixes the “lcok” typo ➜ “lock” and adds a space before the PR link.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad0e88a and 92864d0.

📒 Files selected for processing (1)
  • website/src/content/docs/changelog.md (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/ui/sidebar/render.go:46-48
Timestamp: 2025-04-28T03:48:46.327Z
Learning: The user (lazysegtree) prefers to keep PRs focused and manageable in size, sometimes intentionally leaving TODO comments to track minor issues for later PRs rather than addressing everything at once.
Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.
Learnt from: lazysegtree
PR: yorukot/superfile#781
File: src/internal/model_render.go:254-256
Timestamp: 2025-04-28T04:27:33.074Z
Learning: When race conditions or other issues that are unrelated to the current PR's focus are identified during review, lazysegtree prefers creating separate GitHub issues to track them rather than addressing them in the current PR. This helps maintain PR focus and scope.
Learnt from: lazysegtree
PR: yorukot/superfile#950
File: src/internal/ui/metadata/README.md:7-7
Timestamp: 2025-07-24T03:46:29.484Z
Learning: lazysegtree prefers to defer comprehensive unit testing to separate PRs when the current PR has grown too large, maintaining focus on the primary refactoring objectives while tracking testing requirements in dedicated GitHub issues.
Learnt from: lazysegtree
PR: yorukot/superfile#935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.
Learnt from: lazysegtree
PR: yorukot/superfile#953
File: website/public/install.sh:42-42
Timestamp: 2025-07-21T08:49:44.603Z
Learning: In the superfile bash installer (website/public/install.sh), lazysegtree maintains the same principle as the PowerShell installer - users should supply correct environment variable values (SPF_INSTALL_VERSION without leading 'v') rather than adding validation code to handle malformed input, following the philosophy that users should provide properly formatted values.
Learnt from: lazysegtree
PR: yorukot/superfile#752
File: src/internal/common/load_config.go:27-37
Timestamp: 2025-04-03T16:05:49.630Z
Learning: In the superfile project, configuration struct fields use PascalCase (e.g., "ShellCloseOnSuccess") while their corresponding TOML field names use snake_case (e.g., "shell_close_on_success") as defined in the struct tags. Boolean configuration fields typically don't require explicit validation in the LoadConfigFile function, unlike numeric fields which have range validations.
Learnt from: lazysegtree
PR: yorukot/superfile#953
File: website/public/install.ps1:25-25
Timestamp: 2025-07-21T08:49:13.041Z
Learning: In the superfile PowerShell installer (website/public/install.ps1), lazysegtree prefers that users supply correct environment variable values (like SPF_INSTALL_VERSION without leading 'v') rather than adding validation code to handle malformed input, following the principle that users should provide properly formatted values.
Learnt from: lazysegtree
PR: yorukot/superfile#906
File: src/internal/file_panel.go:11-14
Timestamp: 2025-07-12T05:32:53.131Z
Learning: lazysegtree is concerned about the efficiency impact of adding bounds checking to frequently called methods like getSelectedItem() in file panels, preferring to defer such changes to consider performance implications.
Learnt from: lazysegtree
PR: yorukot/superfile#775
File: src/internal/common/style_function.go:240-243
Timestamp: 2025-04-27T17:04:47.888Z
Learning: lazysegtree plans to refactor textinput.Model creation in the future to fix the code duplication issue that caused a bug where the sidebar search model was created without setting the Width property.
website/src/content/docs/changelog.md (3)

Learnt from: lazysegtree
PR: #935
File: website/src/content/docs/changelog.md:17-26
Timestamp: 2025-07-15T10:32:28.063Z
Learning: In the superfile changelog (website/src/content/docs/changelog.md), lazysegtree prefers to maintain the existing heading format with main version headings using # and sub-sections using #### (Update, Bug fix, Optimization, etc.) consistently throughout all releases, prioritizing established format consistency over strict markdown heading hierarchy compliance.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:25:06.352Z
Learning: PR #770 "Sidebar code separation" is a refactoring and code reorganization effort with no new features. It involves moving code, updating import paths, renaming functions to follow PascalCase convention, and consolidating sidebar-related functionality into a dedicated package.

Learnt from: lazysegtree
PR: yorukot/superfile#0
File: :0-0
Timestamp: 2025-04-12T12:00:32.688Z
Learning: In PR #767 for yorukot/superfile, the focus is on moving code (especially sidebar-related functionality) to a more organized structure without changing functionality. Pre-existing issues should be ignored since the purpose is code reorganization, not fixing existing problems.

🪛 markdownlint-cli2 (0.17.2)
website/src/content/docs/changelog.md

17-17: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4

(MD001, heading-increment)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test (windows-latest)

@lazysegtree lazysegtree requested a review from yorukot July 24, 2025 05:30
@lazysegtree lazysegtree merged commit b444bdb into main Jul 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants