feat(spanner): make admin client gRPC timeout configurable#426
Merged
yoshidan merged 2 commits intoyoshidan:mainfrom Mar 16, 2026
Merged
feat(spanner): make admin client gRPC timeout configurable#426yoshidan merged 2 commits intoyoshidan:mainfrom
yoshidan merged 2 commits intoyoshidan:mainfrom
Conversation
The admin client had hardcoded 30s timeouts for both request and connection, which caused failures during long-running DDL operations (e.g. create/alter table). Add timeout and connect_timeout fields to AdminClientConfig so users can override these values. Defaults remain at 30s for backward compatibility.
Owner
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_database,update_database_ddl) can take well over 30 seconds on real GCP Spanner, causingop.wait()to fail at the transport leveltimeoutandconnect_timeoutfields toAdminClientConfig, defaulting to 30s for backward compatibilityTest plan
cargo check -p gcloud-spannerpasseschange_stream_test.rs) updated to use..Default::default()— no behavioral change