Extract CI test commands to shell scripts and refactor TLS features#427
Merged
Extract CI test commands to shell scripts and refactor TLS features#427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/scripts/CI Script Extraction
Background
Since we use
pull_request_target, workflow files are loaded from the base branch (main).This means changes to feature flags in fork PRs are not reflected in CI, causing test failures.
Changes
.github/scripts/directoryci.yamlto call scripts instead of inline commandsContributors can now modify scripts in their fork and have those changes reflected in CI.
Security is maintained through the existing
safe to testlabel requirement.TLS Feature Refactoring
Changes
default-tlstorustls-tlsas the default TLS backendnative-tlsfeature to support native TLS backendfoundation/auth,pubsub,spanner,storage,kms,bigquery,artifact-registry