Fix github action run #1
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @youandvern - Here's my review!
General suggestions:
- Ensure that the removal of Python 3.9 from the testing matrix is aligned with the project's compatibility and support goals.
- Confirm that the test suite has been updated to reflect the removal of the
csv_to_python_dictionaryfunction to prevent potential issues with failing tests or decreased code coverage.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -16,7 +16,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: ["3.9", "3.10", "3.11"] | |||
| python-version: ["3.10", "3.11"] | |||
There was a problem hiding this comment.
question (testing): I noticed the Python version 3.9 was removed from the testing matrix. While this change might be intentional, it's important to ensure that this decision is aligned with the project's compatibility goals. If the project is still intended to support Python 3.9, we should add tests back for this version to avoid potential regressions. Could you please confirm if dropping Python 3.9 support was a deliberate choice and if so, document the rationale for future reference?
| @@ -3,29 +3,6 @@ | |||
| from efficalc.sections.aisc_wide_flange import WideFlange | |||
|
|
|||
|
|
|||
| def csv_to_python_dictionary(filepath, output_filepath): | |||
There was a problem hiding this comment.
issue (testing): The removal of the csv_to_python_dictionary function seems to be a significant change. However, there's no mention of corresponding updates or additions to the test suite to reflect this change. It's crucial to update the tests to ensure they don't reference or rely on the removed functionality, which could lead to failing tests or decreased code coverage. Could you please verify if the test suite has been updated accordingly and add or modify tests as necessary?
No description provided.