Change PM plotter label, imports, calc report example #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/conc_col_pmm/calc_document/plotting/point_plotter.py # examples/conc_col_pmm/tests/visual_tests/visual_test_document_wrapper.py # examples/conc_col_pmm/tests/visual_tests/visual_test_pmm_plotter_plotly.py # examples/conc_col_pmm/tests/visual_tests/visual_test_point_plotter.py
Reviewer's Guide by SourceryThis PR makes three main types of changes: updates import statements to use absolute imports, adjusts the point plotter label positioning logic, and modifies the calculation report example parameters. Class diagram for updated import statementsclassDiagram
class Input
class get_capacity
class pmm_mesh
class point_plotter
class assign_max_min
class Column
class BarSize
class LoadCombination
class getCalculatedColumnProps
Input <.. get_capacity
Input <.. pmm_mesh
Input <.. point_plotter
Input <.. assign_max_min
Input <.. Column
Input <.. BarSize
Input <.. LoadCombination
Input <.. getCalculatedColumnProps
note for Input "Updated import paths to use absolute imports"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @janderson4 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| # label the intersections with the y-axis | ||
| for i in (0, pt_count - 1): | ||
| pos = (phi_Mn[i], phi_Pn[i]) | ||
| label = str(round(phi_Pn[i], 1)) | ||
| plt.plot(pos[0], pos[1], marker="+", ms=12, mew=1.2, c="black", zorder=3) | ||
| plt.text(pos[0] + label_offsets[0], pos[1] + label_offsets[1], label, zorder=3) | ||
| label_offset_y=label_offsets_y[0] if i==0 else label_offsets_y[1] |
There was a problem hiding this comment.
issue (bug_risk): The variable 'i' is undefined in this scope and could cause incorrect label positioning
This variable was only defined in the previous for-loop scope. Consider basing the y-offset on the point's position relative to the plot bounds instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhance the plotting functionality by adjusting label offsets for better positioning and update import paths in visual test scripts to use absolute paths for improved clarity.
Enhancements: