-
Notifications
You must be signed in to change notification settings - Fork 372
setup runc integration test #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
49beaf8
to
5ea28a2
Compare
I might make further changes, but I’d appreciate any advice on whether the current direction is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be integrated with e2e.yaml.
Hey so a couple of points here,
Thanks for your efforts :) |
5ea28a2
to
82a8044
Compare
d82f53f
to
60a1e04
Compare
Thank you for the review!
I’ve updated it to run using e2e.yaml.
The debug logs are output as part of the tests, specifically when
I’ve updated the configuration accordingly.
Currently, it's set up to run all of the tests (although a few known-hanging tests are skipped within runc_integration_test.sh). I would appreciate any reviews or advice you could provide. |
scripts/runc_integration_test.sh
Outdated
if [[ "$RUNTIME" == "youki" ]]; then | ||
if [[ ! -x ./youki ]]; then | ||
echo "youki binary not found" | ||
exit 1 | ||
fi | ||
cp ./youki "$RUNC_DIR/runc" | ||
chmod +x "$RUNC_DIR/runc" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about passing a path of a binary for runtime?
60a1e04
to
18115ef
Compare
18115ef
to
00cbdac
Compare
For now, I’ve set all failing tests to be skipped. |
Hey @saku3 , thanks for the changes. Let us do this - can we make the CI into a separate CI workflow like podman, I think similar to what you had done originally? That should be the only change from my side, and I'll merge the PR after that. Apologies it is taking so long from our side to get this finished 😓 |
00cbdac
to
650381b
Compare
Signed-off-by: Yusuke Sakurai <[email protected]>
650381b
to
7cc9ae8
Compare
@YJDoc2 The updates since the last PR are as follows:
|
Description
This change allows
runc
integration tests to be executed using theyouki
runtime in CI..github/workflows/runc_integration_tests.yaml
This file configures the CI workflow to run the
runc
integration tests. It performs the following steps:youki
runc
integration tests:bats
runc_integration_test.sh
scripts/runc_integration_test.sh
This script performs the following:
youki
binary at the root of therunc
repository, sincebats
expects the runtime binary to be in that location:https://github.com/opencontainers/runc/blob/main/tests/integration/helpers.bash#L15
bats
command, targeting*.bats
files undertests/integration
:https://github.com/opencontainers/runc/tree/main/tests/integration
skip
commands into.bats
files:https://bats-core.readthedocs.io/en/stable/writing-tests.html#skip-easily-skip-tests
Type of Change
Testing
I have confirmed that all tests pass with runc by executing the following command.(By specifying runc as the first argument, you can run the tests using the runc runtime.)
Related Issues
Part of #3178