-
Notifications
You must be signed in to change notification settings - Fork 152
cobalt: Remove leftover dependency on //chrome/common #6423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cc @yell0wd0g I don't have access to the referenced bug, but it's the same one mentioned in #5960 so I'm assuming it's relevant :-) |
dba9008
to
d0ee45f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a DEPS include rule to prevent this from happening again?
See cobalt/shell/common/DEPS for an example.
I'm known to reuse bugs for only remotely related activities, so had to open it up. |
d0ee45f
to
ad9ccff
Compare
Done! |
Follow-up to youtube#5960, which removed the dependency on //chrome/common:non_code_constants from //cobalt. There was a leftover dependency in the cobalt_unittests target that should also have been removed. Bug: 420684984
ad9ccff
to
c63c61e
Compare
Follow-up to #5960, which removed the dependency on //chrome/common:non_code_constants from //cobalt.
There was a leftover dependency in the cobalt_unittests target that should also have been removed.
Bug: 420684984