Skip to content

cobalt: Remove leftover dependency on //chrome/common #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rakuco
Copy link

@rakuco rakuco commented Jul 15, 2025

Follow-up to #5960, which removed the dependency on //chrome/common:non_code_constants from //cobalt.

There was a leftover dependency in the cobalt_unittests target that should also have been removed.

Bug: 420684984

Copy link

google-cla bot commented Jul 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rakuco
Copy link
Author

rakuco commented Jul 15, 2025

cc @yell0wd0g

I don't have access to the referenced bug, but it's the same one mentioned in #5960 so I'm assuming it's relevant :-)

@rakuco rakuco force-pushed the remove-unused-chrome_common-dependency branch from dba9008 to d0ee45f Compare July 15, 2025 13:36
@kaidokert kaidokert requested review from andrewsavage1, Awallky and haozheng-cobalt and removed request for andrewsavage1 July 15, 2025 21:06
Copy link
Contributor

@Awallky Awallky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

Copy link
Contributor

@Awallky Awallky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a DEPS include rule to prevent this from happening again?
See cobalt/shell/common/DEPS for an example.

@yell0wd0g
Copy link
Contributor

cc @yell0wd0g

I don't have access to the referenced bug, but it's the same one mentioned in #5960 so I'm assuming it's relevant :-)

I'm known to reuse bugs for only remotely related activities, so had to open it up.
The title is "Investigate use of switches for low-powered platforms" : ) so it's
probably a catch-all. IOW it's fine to use it : )

@rakuco rakuco force-pushed the remove-unused-chrome_common-dependency branch from d0ee45f to ad9ccff Compare July 16, 2025 07:59
@rakuco
Copy link
Author

rakuco commented Jul 16, 2025

Could you add a DEPS include rule to prevent this from happening again?
See cobalt/shell/common/DEPS for an example.

Done!

Follow-up to youtube#5960, which removed the dependency on
//chrome/common:non_code_constants from //cobalt.

There was a leftover dependency in the cobalt_unittests target that should
also have been removed.

Bug: 420684984
@rakuco rakuco force-pushed the remove-unused-chrome_common-dependency branch from ad9ccff to c63c61e Compare July 16, 2025 08:00
@rakuco rakuco requested a review from Awallky July 16, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants