Implement base::Lock for event targets. #6429
Open
+52
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 420931375
There are two theories around this crash, 1) there's a race condition between firing event listeners and adding/removing them. 2) it occurs during page teardown when event handlers are destroyed but UMA is still trying to fire the event handler and upload payloads.
This PR adds a lock implementation to tackle the race condition and checks for execution context in H5vcc metrics to prevent UMA metrics upload when during page teardown.