Refactored code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am applying for a Junior role at YouView so was looking through the open-source codebase to familiarise myself with it. This pull request consists of: Refactored if/else into a ternary operator Removal of some strictly equals signs where deemed unnecessary. Please don't feel the need to approve these changes, especially if the refactoring is unnecessary here or might not fit with tests already written. I was simply familiarising myself with the codebase as I do quite enjoy contributing to open-source projects. If, however, you do feel like approving them, I would be thrilled. If you need any further help refactoring, I would love to continue to help where I can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am applying for a Junior role at YouView so was looking through the open-source codebase to familiarise myself with it.
This pull request consists of:
Refactored if/else into a ternary operator
Removal of some strictly equals signs where deemed unnecessary.
Please don't feel the need to approve these changes, especially if the refactoring is unnecessary here or might not fit with tests already written. I was simply familiarising myself with the codebase as I do quite enjoy contributing to open-source projects.
If, however, you do feel like approving them, I would be thrilled. If you need any further help refactoring, I would love to continue to help where I can.