Support Dim 2/1 and Fix Bug #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still uses derived_func(const int, const long*, const char*, yt_array*) as the interface for the simulation for 2dim, though the last element will be empty.
…t used. Is there a way to properly wrap different data structure in GetLocalFieldData. Currently, contiguous_in_x is not used in AmrDataArray1D. I added it so that I don't have to explicitly make another GenerateLocalFieldData for 1D.
This is because based on the dimensionality, we need to instantiate different data class and rma.
[Bug] there is a bug of swapping axis when wrapping while GenerateLocalFieldData already did that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
Fix Bug