Skip to content

Conversation

@cindytsai
Copy link
Collaborator

@cindytsai cindytsai commented Aug 23, 2025

Doc

  • Remove version requirements in numpy dependency. Version 1.x and 2.x should work.

Bug

  • Fix setting should we free this new allocation flag in DataHubAmrParticle when preparing existing particle data for other processes.
  • readline/readline.h needs to include cstdio header. (This is super weird and only happens in fedora. First found in fedora)

@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@1c760d9). Learn more about missing BASE report.
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/data_hub_amr.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage        ?   58.05%           
=======================================
  Files           ?       52           
  Lines           ?     6874           
  Branches        ?     1128           
=======================================
  Hits            ?     3991           
  Misses          ?     2856           
  Partials        ?       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cindytsai cindytsai merged commit 9a9f33c into yt-project:main Aug 24, 2025
38 checks passed
@cindytsai cindytsai deleted the fix branch August 24, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant