ENH: enable strict zip (almost) everywhere
#570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
zip (almost) everywhere
neutrinoceros
commented
Mar 13, 2025
| """ | ||
| for arg_name, arg_value in chain(zip(names_of_args, args), kwargs.items()): | ||
| for arg_name, arg_value in chain( | ||
| zip(names_of_args, args, strict=False), kwargs.items() |
Member
Author
There was a problem hiding this comment.
this is the one place where I used strict=False because it makes sense in this context: when all arguments are passed as keywords, args is empty an d names_of_args is effectively the same as list(kwargs.keys())
neutrinoceros
force-pushed
the
enh/strict_zip
branch
2 times, most recently
from
f5d0da2 to
1219576
Compare
neutrinoceros
changed the title
zip (almost) everywherezip (almost) everywhere (⏰ wait for #567)
neutrinoceros
force-pushed
the
enh/strict_zip
branch
from
1219576 to
022d8b7
Compare
neutrinoceros
changed the title
zip (almost) everywhere (⏰ wait for #567)zip (almost) everywhere
neutrinoceros
force-pushed
the
enh/strict_zip
branch
from
022d8b7 to
682e782
Compare
neutrinoceros
force-pushed
the
enh/strict_zip
branch
from
9ff8fb1 to
49424e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off #567
Close #568