Skip to content

Conversation

@neutrinoceros
Copy link
Member

I don't think the current activity on this repo justifies the added complexity and potential instability that comes with setuptools-scm, and setuptools itself, while heroically maintained throughout the years, is a complex beast I'd rather avoid every time a simpler alternative exists. flit-core is just that. It has already being used in most of my pure-python repos (including yt-project/cmyt) for about a year now and I didn't encounter any issue, so I'm proposing to make the switch in unyt too.

@neutrinoceros neutrinoceros marked this pull request as ready for review October 25, 2025 14:14
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favour of this, especially given that I value your knowledge in managing these repos.

To quote their website:

Make the easy things easy and the hard things possible is an old motto from the Perl community. Flit is entirely focused on the easy things part of that, and leaves the hard things up to other tools.

]

build-backend = "setuptools.build_meta"
requires = ["flit_core >=3.11,<4"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use <5 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 4 doesn't exist yet, so who knows if it'll be compatible ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering why there is a difference compared to the suggested config on the flit website (https://flit.pypa.io/en/stable/pyproject_toml.html#build-system-section).

Copy link
Member Author

@neutrinoceros neutrinoceros Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There... isn't ? At least I don't see any

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! It looks like not only LLMs have hallucinations sometimes, my apologies :/ !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, found it again. There is a difference when compared to their latest (rather than stable) version of the doc (https://flit.pypa.io/en/latest/pyproject_toml.html#build-system-section). But pinning <4 looks good to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I ended up learning there's a roadmap for flit 4.0 at pypa/flit#673
Welp, it'll be easy enough to upgrade once it's there, but thanks for noticing this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants