-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to yt.hub for hosting data files #108
base: main
Are you sure you want to change the base?
Conversation
@yt-fido test this please. |
This completely breaks yt.load_sample, see https://github.com/yt-project/yt/blob/89424c2196ff29629f2066a188e44e946099fca2/yt/sample_data/api.py#L88 I am nonetheless fine with it, because I don't like that yt.load_sample relies on this file instead of the website itself, but I would really like that we think of a solution before we ship this. |
There's going to be an endpoint that generates json required by |
yeah it looks okay, and I think this is actually an improvement for yt.load_sample too. I wrote my first comment very quickly to avoid a pre-mature merge. Now I think it should be pretty easy to patch the yt side first and then all is well ! |
The removal of |
@Xarthisius @neutrinoceros what's the status of this? |
@jzuhone I believe this PR was a companion to yt-project/yt#3366 |
Should we still try to push this? |
No more hand-editing of json files...