Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix missing data sample registration and loading non-tarballs #3347

Merged
merged 3 commits into from
Apr 4, 2022
Merged

BUG: fix missing data sample registration and loading non-tarballs #3347

merged 3 commits into from
Apr 4, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jun 9, 2021 •
edited
Loading

PR Summary

fix #3341

  • fix a bug in load_sample where non-tarballs files couldn't be moved to the test-data-dir
  • register sample datasets cm1_tornado, SmartStars, tiny_fof_halos
  • update broken urls

note: two of the datasets reported in #3341 cannot be trivially fixed for now, namely:

@neutrinoceros neutrinoceros added bug api-consistency naming conventions, code deduplication, informative error messages, code smells... labels Jun 9, 2021
@neutrinoceros neutrinoceros marked this pull request as draft June 9, 2021 09:10
@neutrinoceros neutrinoceros marked this pull request as ready for review June 19, 2021 09:41
@neutrinoceros neutrinoceros requested a review from Xarthisius June 19, 2021 09:41
@neutrinoceros neutrinoceros force-pushed the fix_missing_data_sample_registrations branch from 115020f to b048f96 Compare June 19, 2021 11:07
@neutrinoceros neutrinoceros mentioned this pull request Jun 19, 2021
Closed
@neutrinoceros neutrinoceros marked this pull request as draft August 31, 2021 09:27
@neutrinoceros neutrinoceros reopened this Nov 25, 2021
@neutrinoceros
Copy link
Member Author

closed-reopen to rettriger tests. Long term, this will be superseded by #3366, but I think it still has value so I'll reopen. Actually it also has one approval already so maybe it could be considered for inclusion in yt 4.0.2 ?

@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Nov 25, 2021
@neutrinoceros neutrinoceros changed the title load_sample: fix missing data sample registration BUG: fix missing data sample registration and loading Nov 25, 2021
@neutrinoceros neutrinoceros changed the title BUG: fix missing data sample registration and loading BUG: fix missing data sample registration and loading non-tarballs Nov 25, 2021
@neutrinoceros neutrinoceros marked this pull request as ready for review November 25, 2021 17:56
@neutrinoceros neutrinoceros removed this from the 4.0.2 milestone Nov 25, 2021
@neutrinoceros
Copy link
Member Author

Let's try to get some attention to this PR for 4.0.3

@neutrinoceros neutrinoceros added this to the 4.0.3 milestone Mar 31, 2022
@cphyc cphyc merged commit 11fe640 into yt-project:main Apr 4, 2022
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Apr 4, 2022
@cphyc @meeseeksmachine
Backport PR yt-project#3347: BUG: fix missing data sample registratio…
9a33adc 
…n and loading non-tarballs
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 4, 2022
Merged
@neutrinoceros neutrinoceros deleted the fix_missing_data_sample_registrations branch April 4, 2022 16:35
neutrinoceros added a commit that referenced this pull request Apr 4, 2022
@neutrinoceros
Merge pull request #3883 from meeseeksmachine/auto-backport-of-pr-334…
a42a20c 
…7-on-yt-4.0.x

Backport PR #3347 on branch yt-4.0.x (BUG: fix missing data sample registration and loading non-tarballs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

@Xarthisius Xarthisius Awaiting requested review from Xarthisius

Assignees
No one assigned
Labels
api-consistency naming conventions, code deduplication, informative error messages, code smells... bug
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.

load_sample: some datasets are missing registration
2 participants
@neutrinoceros @cphyc