BLD: forbid deprecated numpy C API #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
infrastructure
neutrinoceros
changed the title
neutrinoceros
added
build
neutrinoceros
force-pushed
the
no_npy_deprecated_api
branch
from
65aad58
to
443e291
Compare
neutrinoceros
changed the title
Xarthisius
approved these changes
Aug 3, 2023
|
read through the cython 3 link in the linked issue and it says:
Would we get test failures with this PR if that were the case for us? edit: I guess my more relevant question: are we building with cython 3 already? (dont have time to look myself at the moment...) |
|
Yes we are ! We switched the requirements to Cython>3.0 in a previous PR, so I expect we'd see errors in CI if this was impacting us. |
chrishavlin
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #4606