TYP: fix type-checking incompatibilities with matplotlib 3.8 #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
tests: running tests
neutrinoceros
force-pushed
the
test_mpl_3.8
branch
from
ed79817
to
af5fd73
Compare
|
No problems at runtime (hurray), but lots of errors at type-check time. I think most of them may be noise, to be reported upstream, but I can try to fix the rest of them first. |
neutrinoceros
force-pushed
the
test_mpl_3.8
branch
5 times, most recently
from
5935277
to
715f441
Compare
|
Actually everything seems to be fixable on our end, and I think I'm almost there |
neutrinoceros
force-pushed
the
test_mpl_3.8
branch
2 times, most recently
from
5437c37
to
82e66a1
Compare
neutrinoceros
changed the title
neutrinoceros
added
enhancement
neutrinoceros
force-pushed
the
test_mpl_3.8
branch
from
82e66a1
to
4dafd9d
Compare
|
It's not extremely urgent yet but I would like merging this before matplotlib 3.8.0 is actually released to smooth out the transition. May I ? |
|
Ok by me, seems small enough. But I'm also the only approval so i feel like it'd be good to get an additional OK from someone else :) |
|
Ok I'll leave it up for now, but will probably merge it if matplotlib 3.8 comes up first :) |
jzuhone
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a test-only PR, not meant to be merged.In particular, test newly supported type-checking for Python >= 3.9
edit: this has now survived type-checking with matplotlib 3.8.0rc1, so I rewrote the branch history to preserve dependencies and fix newly discovered type-checking incompatibilities instead.