Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop support for CPython 3.8 #4659

Merged
merged 9 commits into from
Sep 6, 2023

Conversation

neutrinoceros
Copy link
Member

Following my recent email, closes #4302

@neutrinoceros neutrinoceros added the dependencies Pull requests that update a dependency file label Sep 3, 2023
@neutrinoceros neutrinoceros added this to the 4.3.0 milestone Sep 3, 2023
@neutrinoceros neutrinoceros marked this pull request as draft September 3, 2023 16:53
@neutrinoceros neutrinoceros added the enhancement Making something better label Sep 3, 2023
@neutrinoceros
Copy link
Member Author

@yt-fido test this please

1 similar comment
@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

2 similar comments
@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work! For reference, could you comment on the upgrades required to make nose work?

@neutrinoceros
Copy link
Member Author

@cphyc As far as I know nose is just patched as follow

python3.10 -m pip install nose nose-exclude
find .venv/lib/python*/site-packages/nose -name "*.py" -exec sed -i -e 's/collections.Callable/collections.abc.Callable/g' {} \;

see #4302 (comment)
Maybe @Xarthisius has more insight on this.

@Xarthisius
Copy link
Member

@cphyc As far as I know nose is just patched as follow

python3.10 -m pip install nose nose-exclude
find .venv/lib/python*/site-packages/nose -name "*.py" -exec sed -i -e 's/collections.Callable/collections.abc.Callable/g' {} \;

see #4302 (comment) Maybe @Xarthisius has more insight on this.

That's everything I did.

@matthewturk matthewturk merged commit 9cea1b1 into yt-project:main Sep 6, 2023
16 checks passed
@neutrinoceros neutrinoceros deleted the drop_cp38 branch September 6, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: how to drop CPython 3.8 ?
4 participants