Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP: drop support for Python 3.9 #4979

Merged
merged 5 commits into from
Oct 7, 2024
Merged

DEP: drop support for Python 3.9 #4979

merged 5 commits into from
Oct 7, 2024

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Sep 3, 2024 •
edited
Loading

PR Summary

Tentatively close #4977 (the nose patching bit is experimental at the time of opening)

this is currently based off #4941 to avoid a conflict

@matthewturk
Copy link
Member

Is anyone else still supporting py39?

@neutrinoceros
Copy link
Member Author

Yeah, I mean, Cython still hasn't dropped 2.7 yet (at least not in a stable release)
More seriously, matplotlib still supports 3.9 but NumPy doesn't. SPEC 0 recommends dropping 3.10 next month so I don't feel too guilty about proposing this now.

@matthewturk
Copy link
Member

That works for me. And let's get #4941 in first so this is a smaller one.

@neutrinoceros neutrinoceros added tests: running tests Issues with the test setup dependencies Pull requests that update a dependency file labels Sep 3, 2024
@neutrinoceros neutrinoceros force-pushed the dep/drop_cp39 branch 2 times, most recently from 2049322 to b9fe508 Compare September 3, 2024 20:35
@neutrinoceros neutrinoceros added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Sep 3, 2024
@neutrinoceros neutrinoceros force-pushed the dep/drop_cp39 branch 4 times, most recently from 073fa16 to 790e39b Compare September 14, 2024 09:35
@neutrinoceros neutrinoceros marked this pull request as ready for review September 14, 2024 11:36
@neutrinoceros
Copy link
Member Author

This is ready for review. As usual with these, it'll require some voodoo from a code owner (@matthewturk, @Xarthisius)

@neutrinoceros neutrinoceros mentioned this pull request Sep 18, 2024
Closed
@neutrinoceros
Copy link
Member Author

rebased to fix conflicts

@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Oct 5, 2024
@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@Xarthisius Xarthisius merged commit 0e6a608 into yt-project:main Oct 7, 2024
21 checks passed
@neutrinoceros
Copy link
Member Author

Thanks @Xarthisius !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzuhone jzuhone jzuhone approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

DEP: can we drop support for Python 3.9 now ?
4 participants
@neutrinoceros @matthewturk @jzuhone @Xarthisius