Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: add CPython 3.13 to regular test matrix #5021

Merged
merged 1 commit into from
Oct 31, 2024
Merged

TST: add CPython 3.13 to regular test matrix #5021

merged 1 commit into from
Oct 31, 2024

Conversation

neutrinoceros
Copy link
Member

PR Summary

close #4931, and replace #4958

This was referenced Oct 8, 2024
Closed
Closed
@neutrinoceros neutrinoceros added tests: running tests Issues with the test setup infrastructure Related to CI, versioning, websites, organizational issues, etc labels Oct 8, 2024
@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Oct 8, 2024
@neutrinoceros
Copy link
Member Author

neutrinoceros commented Oct 8, 2024 •
edited
Loading

This isn't necessarily a blocker for yt 4.4.0 and can be removed from the milestone if it takes too long to resolve issues upstream.
The current failure we're seeing on windows appears to be caused by netcdf4 not having wheels on PyPI yet.
xref Unidata/netcdf4-python#1370

@neutrinoceros neutrinoceros added the do not merge this change should not be merged until later label Oct 10, 2024
@neutrinoceros
Copy link
Member Author

trying out disabling netcdf4 temporarily as an experiment to see if anything else is currently blocking. Will revert that commit before I undraft.

@neutrinoceros neutrinoceros force-pushed the tst/cp313 branch 2 times, most recently from 252b753 to 1189b7b Compare October 10, 2024 19:06
@neutrinoceros
Copy link
Member Author

also disabling mpi4py since it also fails to build on Windows for some reason (it's complaining that MPI itself isn't installed, but I don't think we previously did anything special to have it available on Windows images and it compiled just fine with Python 3.12 🤷🏻‍♂️)

@neutrinoceros
Copy link
Member Author

ok looks like that's everything. I want to report the build failure for mpi4py upstream because it seems unknown at the moment and I have no idea what's the actual issue. I'll try to do this tomorrow.

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Oct 12, 2024 •
edited
Loading

I was pleasantly surprised to discover, while trying to come up with a minimal reproducer to illustrate my report, that mpi4py 4.0.1 was released yesterday and appeared to fix the build issue on Windows + Python 3.13, so it should really be just down to netcdf4 now.

@neutrinoceros
Copy link
Member Author

netCDF4 1.7.2 just dropped, let's try this again

@neutrinoceros neutrinoceros removed the do not merge this change should not be merged until later label Oct 22, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review October 23, 2024 16:12
@neutrinoceros neutrinoceros merged commit 1bb278b into yt-project:main Oct 31, 2024
21 checks passed
@neutrinoceros neutrinoceros deleted the tst/cp313 branch October 31, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees
No one assigned
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

CPython 3.13 support (tracker issue)
2 participants
@neutrinoceros @chrishavlin