Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch xradar pin to arm-pyart pin in tests #5048

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

chrishavlin
Copy link
Contributor

@chrishavlin chrishavlin commented Nov 8, 2024

new arm-pyart release is out. So close #5044 ... and hopefully #5047 ??

@chrishavlin chrishavlin added code frontends Things related to specific frontends infrastructure Related to CI, versioning, websites, organizational issues, etc labels Nov 8, 2024
@chrishavlin
Copy link
Contributor Author

chrishavlin commented Nov 8, 2024

I just realized that anything that is added to the pyproject.toml test target will always be installed, even in the minimal test suite (the ci_install.sh script will do a python -m pip install -e ".[test]" -r minimal_requirements.txt for the minimal test). So having arm-pyart (or previously xradar) in the test target will mean that it will always be installed (which will include xarray and lots of other dependencies). That doesn't seem ideal... I'm tempted to just pin arm-pyart in the frontend requirements instead?

pyproject.toml Outdated Show resolved Hide resolved
@chrishavlin
Copy link
Contributor Author

ok, just pushed a new version to just bump the min arm-pyart version. It's a pretty big jump in versions from what we had... but realistically I think it'd be tough to get a working environment at v<1.19.2 with all the shuffling of the arm-pyart dependencies that happened.

@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Nov 8, 2024
@neutrinoceros neutrinoceros enabled auto-merge (squash) November 8, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code frontends Things related to specific frontends infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin xradar in tests when possible
2 participants