Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yugabyte/yugabyte-db#20410] Add annotation MinimumYBVersion for tests #315

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vaibhav-yb
Copy link
Collaborator

Problem

Currently, the test infra has a lot of tests and they are all compatible with the latest master branch at yugabyte/yugabyte-db but some of these tests are only compatible with the latest branch as the features are not available in previous versions.

Naturally, when these tests will be run against a previous YB version, they will fail, thus polluting the test results with failures.

Solution

This PR introduces an annotation @MinimumYBVersion which adds the ability to a test to be run only when the service version is equal to or greater than the specified version for test, if the service version is less, the test will be skipped/disabled.

Changes

  1. Added class YBVersion to denote YugabyteDB version for service
  2. Added annotation MinimumYBVersion and it's condition evaluation in the class RunWithMinimumYBVersion

Note:
The added annotation fetches the current YB version from the environment variable YB_DOCKER_IMAGE so it is mandatory for this environment variable to be set while running the tests, otherwise the current version will be defaulted to 2.21.0.0

Additionally, this closes yugabyte/yugabyte-db#20410

@vaibhav-yb vaibhav-yb added the enhancement New feature or request label Jan 2, 2024
@vaibhav-yb vaibhav-yb self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDCSDK] DBZ: Enhance test infra to specify minimum YB version to run tests against
1 participant