Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PWA #43

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Add PWA #43

merged 3 commits into from
Dec 17, 2023

Conversation

shoedler
Copy link
Collaborator

@shoedler shoedler commented Dec 16, 2023 •
edited
Loading

  • Added & Configured PWA Support
  • Added favicon and PWA Icons
  • Could not upgrade to Angular 17, bc Nebular is not ready (Support for Angular 17 akveo/nebular#3225)
    I had to install Angular PWA @ v16, which has conflicting peer dependencies with the legacy deps that nebular requires.

npm ci in the workspace root does no longer work! Must use npm i --legacy-peer-deps

  • Adjusted ci pipeline to use this command

Todo

@shoedler shoedler marked this pull request as ready for review December 16, 2023 16:57
@shoedler shoedler requested review from Raemy92 and yungxramoz and removed request for Raemy92 December 16, 2023 17:10
@shoedler shoedler self-assigned this Dec 16, 2023
@shoedler shoedler changed the base branch from main to feat/view-event-comments December 16, 2023 17:11
@shoedler shoedler mentioned this pull request Dec 16, 2023
Merged
1 task
yungxramoz
yungxramoz previously approved these changes Dec 16, 2023
View reviewed changes
Base automatically changed from feat/view-event-comments to main December 17, 2023 11:53
@shoedler shoedler dismissed yungxramoz’s stale review December 17, 2023 11:53

The base branch was changed.

@shoedler shoedler merged commit cdba07f into main Dec 17, 2023
3 checks passed
@shoedler shoedler deleted the feat/add-pwa branch December 17, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungxramoz yungxramoz yungxramoz left review comments

@Raemy92 Raemy92 Awaiting requested review from Raemy92

Assignees

@shoedler shoedler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoedler @yungxramoz