Liveness probe listens to both IPV4 and IPV6 interfaces #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to fix the e2e test and if that passes ill merge this. I guess in the next days I hope I find the time for this. |
|
I can not found nothing on the docs that tells me this listens on both ipv6 and ipv4. Anyway the tests are passing. |
|
It's standard that "::" listens on both IPv4 and IPv6. The square brackets "[ ]" are needed in the URL for the syntax to be correct. Kopf code: https://github.com/nolar/kopf/blob/main/kopf/_core/engines/probing.py#L71 |
|
Hello, any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the liveness probe listen on both IPV4/IPV6 interfaces
Fixes #123