Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url configurable on the command call #4

Closed
wants to merge 1 commit into from
Closed

Make url configurable on the command call #4

wants to merge 1 commit into from

Conversation

jmcs
Copy link
Member

@jmcs jmcs commented Dec 9, 2015

No description provided.

@prayerslayer
Copy link

What is the use case for this? It makes sense in pierone-cli as we have two of them, but there is only one Kio.

@jmcs
Copy link
Member Author

jmcs commented Dec 9, 2015

I need to use kio from lizzy. I want to make the url configurable with an environmental variable, and I would prefer not having to write a config file on startup, with this option I can just pass the URL in every call.

@prayerslayer
Copy link

Hmm to me that sounds like a special use case where you already have a solution to (echo "{ url: <kio url> }" > ~/.config/kio.yaml) but very few other people would benefit from it. I'd rather not introduce that change, but I'm not the maintainer, so don't listen to me.

@hjacobs
Copy link
Contributor

hjacobs commented Dec 9, 2015

@jmcs I agree with @prayerslayer, but I propose an alternative: we can make the config loading generic to consider environment variables too

@hjacobs
Copy link
Contributor

hjacobs commented Dec 9, 2015

@hjacobs
Copy link
Contributor

hjacobs commented Dec 11, 2015

Changed the stups-cli-support to allow overwritting via ENV vars.

@hjacobs hjacobs closed this Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants