-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Separate pipeline for internal/external build and support multi arch #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deployment ChecklistThis change falls under the deployment policy. 💁 Since Nov 10th, we are in the RED deployment zone. This means all changes released to production must adhere to the following requirements:
👉 Regardless of which boxes you click in this comment, merge/deployment will not be blocked. |
|
|
||
| IMAGE ?= registry.opensource.zalan.do/acid/$(BINARY) | ||
| BASE_IMAGE ?= alpine:latest | ||
| IMAGE ?= ghcr.io/zalando/$(BINARY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it is not used to ghcr build (direct Dockerfile usage), i would make it just postgres-operator for local builds
| .PHONY: clean test appjs docker push mock | ||
|
|
||
| IMAGE ?= registry.opensource.zalan.do/acid/postgres-operator-ui | ||
| IMAGE ?= ghcr.io/zalando/postgres-operator-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for the naming
|
|
||
| IMAGE ?= registry.opensource.zalan.do/acid/postgres-operator-ui | ||
| IMAGE ?= ghcr.io/zalando/postgres-operator-ui | ||
| BASE_IMAGE ?= alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without tag?
The current Postgres operator uses the open-source registry, which has expired. We need to move to zECR for internal use, but internal policy restricts open-source base images
Closes #2970