Refactor net.Error.Temporary #2149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonCoder95
force-pushed
the
fix-1992
branch
from
96f6246 to
435ae99
Compare
|
|
demonCoder95
force-pushed
the
fix-1992
branch
from
e384fa0 to
1adb2c3
Compare
szuecs
reviewed
Nov 24, 2022
szuecs
reviewed
Nov 24, 2022
szuecs
reviewed
Nov 24, 2022
szuecs
reviewed
Nov 24, 2022
|
I'll add unit tests for |
Signed-off-by: noor <[email protected]>
Signed-off-by: noor <[email protected]>
demonCoder95
force-pushed
the
fix-1992
branch
from
1adb2c3 to
ca30e58
Compare
Signed-off-by: noor <[email protected]>
demonCoder95
force-pushed
the
fix-1992
branch
from
ca30e58 to
6c45b91
Compare
|
I refactored the temporary error tests for timeout error and it seems the tests were broken. Any ideas on how to fix that? Also, I'll take a look at some production logs, as suggested on the linked issue to check for appropriate error strings. |
szuecs
reviewed
Nov 30, 2022
| func (err testError) Timeout() bool { return false } | ||
| func (err testError) Temporary() bool { return true } | ||
| func (err testError) Error() string { return "test error" } | ||
| func (err testError) Timeout() bool { return false } |
There was a problem hiding this comment.
Maybe the tests are waiting for Timeout() returning true?
I see that you wait for some log message but maybe it's the condition that is now different, because Temporary was "true" and Timeout is "false"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fix for #1992.