Skip to content

Conversation

@mjungsbluth
Copy link
Collaborator

@mjungsbluth mjungsbluth commented Sep 19, 2025

This PR passes through existing Prometheus metrics from Open Policy Agent by prefixing them to fit with remainging Skipper metrics and labeling them per virtual OPA instance.

This can only be supported for the Prometheus metrics flavour and is breaking the metrics abstraction as it pulls the Prometheus Registerer to the outside but avoids maintaining and copying existing work that has happened upstream in Open Policy Agent.

Should only be merged after #3562 is merged

@mjungsbluth mjungsbluth added the major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs label Sep 19, 2025
@mjungsbluth mjungsbluth marked this pull request as ready for review September 30, 2025 14:02
@szuecs
Copy link
Member

szuecs commented Oct 10, 2025

👍

@mjungsbluth
Copy link
Collaborator Author

@torwunder could you also have a look?

@szuecs szuecs force-pushed the opa_prometheus_metrics branch from d7888f6 to bde6d0d Compare January 15, 2026 18:27
test: add label validation

Signed-off-by: Sandor Szücs <[email protected]>
@szuecs szuecs force-pushed the opa_prometheus_metrics branch from f08bc6e to 2972e4f Compare January 15, 2026 18:31
@szuecs szuecs requested a review from MustafaSaber January 15, 2026 18:31
@szuecs
Copy link
Member

szuecs commented Jan 15, 2026

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants