Merged
Conversation
mjungsbluth
added
the
major
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
Member
|
👍 |
mjungsbluth
force-pushed
the
opa_prometheus_metrics
branch
from
b312fc6 to
e5f79ef
Compare
Collaborator
Author
|
@torwunder could you also have a look? |
torwunder
reviewed
Oct 15, 2025
szuecs
reviewed
Oct 24, 2025
szuecs
force-pushed
the
opa_prometheus_metrics
branch
from
e5f79ef to
55e6d63
Compare
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
szuecs
force-pushed
the
opa_prometheus_metrics
branch
from
d7888f6 to
bde6d0d
Compare
test: add label validation Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
opa_prometheus_metrics
branch
from
f08bc6e to
2972e4f
Compare
Member
|
👍 |
1 similar comment
Collaborator
Author
|
👍 |
x418
pushed a commit
to x418/kubernetes-on-aws
that referenced
this pull request
Jan 26, 2026
## What & Why? Part of [Expose OPA Status Metrics](https://github.com/zalando-infosec/corporate-iam-issues/issues/1331) This change to the OPA configmap ensures that the PrometheusOverride hook added via zalando/skipper#3631 enables the Status metrics that we plan to consume.
This was referenced Jan 26, 2026
x418
added a commit
to x418/skipper
that referenced
this pull request
Jan 30, 2026
…PA status metrics What & Why? Implement ConfigDiscoveryHook.OnConfigDiscovery() for PrometheusOverride to enable Prometheus status metrics when using discovery bundles. zalando#3631 added support to also expose native OPA metrics via Skipper's metrics endpoint. This PR extends it by also ensuring that we also enable it when using discovery bundles
x418
added a commit
to x418/skipper
that referenced
this pull request
Jan 30, 2026
…PA status metrics ## What & Why? Implement ConfigDiscoveryHook.OnConfigDiscovery() for PrometheusOverride to enable Prometheus status metrics when using discovery bundles. zalando#3631 added support to also expose native OPA metrics via Skipper's metrics endpoint. This PR extends it by also ensuring that we also enable it when using discovery bundles Signed-off-by: Santhosh Kannan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes through existing Prometheus metrics from Open Policy Agent by prefixing them to fit with remainging Skipper metrics and labeling them per virtual OPA instance.
This can only be supported for the Prometheus metrics flavour and is breaking the metrics abstraction as it pulls the Prometheus
Registererto the outside but avoids maintaining and copying existing work that has happened upstream in Open Policy Agent.Should only be merged after #3562 is merged