-
Notifications
You must be signed in to change notification settings - Fork 378
Enable native OPA Prometheus metrics #3631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mjungsbluth
wants to merge
6
commits into
master
Choose a base branch
from
opa_prometheus_metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+220
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
Member
|
👍 |
b312fc6 to
e5f79ef
Compare
Collaborator
Author
|
@torwunder could you also have a look? |
torwunder
reviewed
Oct 15, 2025
szuecs
reviewed
Oct 24, 2025
e5f79ef to
55e6d63
Compare
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
d7888f6 to
bde6d0d
Compare
test: add label validation Signed-off-by: Sandor Szücs <[email protected]>
f08bc6e to
2972e4f
Compare
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
major
moderate risk, for example new API, small filter changes that have no risk like refactoring or logs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes through existing Prometheus metrics from Open Policy Agent by prefixing them to fit with remainging Skipper metrics and labeling them per virtual OPA instance.
This can only be supported for the Prometheus metrics flavour and is breaking the metrics abstraction as it pulls the Prometheus
Registererto the outside but avoids maintaining and copying existing work that has happened upstream in Open Policy Agent.Should only be merged after #3562 is merged