Feature: net package valkey ring client implementation #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
force-pushed
the
feature/valkey-ring
branch
from
36b312d to
e746986
Compare
Signed-off-by: Sandor Szücs <[email protected]>
…uration Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
refactor: sort imports Signed-off-by: Sandor Szücs <[email protected]>
doc: fix valkeytest package doc Signed-off-by: Sandor Szücs <[email protected]>
…drop t.Helper() Signed-off-by: Sandor Szücs <[email protected]>
nop: cleanup feature: enable users to pass metrics interfae for example for tests passing mockmetrics Signed-off-by: Sandor Szücs <[email protected]>
feature: valkey lua script Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
feature: optional OTel client Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
… implemented feature Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
…aths feature: tracing and add default tracer test: add tests for valkey.Hook Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
feature/valkey-ring
branch
2 times, most recently
from
29d58b4 to
59ea15d
Compare
… net package Signed-off-by: Sandor Szücs <[email protected]>
szuecs
commented
Jan 14, 2026
|
|
||
| // maps int to client for sharding, trades memory for concurrent access | ||
| // most operations only have to use this lock-free structure | ||
| shards [ringSize]valkey.Client |
Member
Author
There was a problem hiding this comment.
this data structure is the key for the lock free access
szuecs
commented
Jan 14, 2026
| if i%shardSize == 0 { | ||
| cur++ | ||
| } | ||
| vr.shards[i] = clients[cur] |
Member
Author
There was a problem hiding this comment.
here we set the values of the lock free data structure, if we get called by SetAddr() , for example scliang-out valkey instances
szuecs
commented
Jan 14, 2026
|
|
||
| // shardForKey does the lookup for valkey most operations to find the valkey ring shard | ||
| func (vr *valkeyRing) shardForKey(key string) valkey.Client { | ||
| return vr.shards[xxhash.Sum64String(key)%ringSize] |
Member
Author
There was a problem hiding this comment.
this is the O(1) lock free lookup of the valkey client connected to the right shard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: net package valkey ring client implementation
This is the basic block to have another Swarmer implementation to implement for example
cluster*Ratelimitfilters.In order to allow migration from redis to valkey, this is the first step out of two.
ref #3799
valkey command sheet: https://valkey.io/commands