Ns/rename pp crs #1760
Open
Ns/rename pp crs #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
added
the
data_PR
nsarlin-zama
force-pushed
the
ns/rename_pp_crs
branch
2 times, most recently
from
5926757
to
808cc7c
Compare
nsarlin-zama
force-pushed
the
ns/rename_pp_crs
branch
from
808cc7c
to
e0c703e
Compare
BREAKING_CHANGE: - All the zk API (build_with_proof, verify, verify_and_expand,...) now take a `CompactPkeCrs` instead of a `CompactPkePublicParams`. Serialized `CompactPkePublicParams` from previous versions can be converted into a `CompactPkeCrs` using `params.into()`
nsarlin-zama
force-pushed
the
ns/rename_pp_crs
branch
from
e0c703e
to
e93770b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/800#issue-2603108396
PR content/description
Use the CompactPkeCrs instead of the CompactPkePublicParams. It simplifies a bit the workflow for users, they generate a crs and are directly able to use it and serialize it without having to extract the params.
Having a release 0.11 in Cargo.toml was necessary to be able to update the data repo.
Check-list: