-
Notifications
You must be signed in to change notification settings - Fork 29
chore: upgrade go version, add tests and comments, and fix arg names #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mmadu Manasseh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pkg/kustomize/process.go:50
- Switching the logging level from Info to Debug may reduce the visibility of directory processing logs in production. Please confirm that this change is intentional for operational monitoring.
log.Debug().Msgf("processing directory %q", relBase)
Signed-off-by: Mmadu Manasseh <[email protected]>
Temporary image deleted. |
Signed-off-by: Mmadu Manasseh <[email protected]>
Signed-off-by: Mmadu Manasseh <[email protected]>
Signed-off-by: Mmadu Manasseh <[email protected]>
Signed-off-by: Mmadu Manasseh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (3)
- .tool-versions: Language not supported
- go.mod: Language not supported
- tools/dump_crds/go.mod: Language not supported
Comments suppressed due to low confidence (2)
pkg/argo_client/kustomize.go:38
- The use of log.Printf for error logging is inconsistent with the rest of the codebase that uses zerolog. Consider using log.Error().Err(err).Msg(...) for consistency.
defer func() { if err := r.Close(); err != nil { log.Printf("failed to close file: %v", err) } }() // ignore error: file was opened read-only.
pkg/config/config.go:88
- Despite updating the mapstructure tag, the internal field name 'MaxConcurrenctChecks' remains misspelled. Consider renaming it to 'MaxConcurrentChecks' for clarity and consistency.
MaxConcurrenctChecks int `mapstructure:"max-concurrent-checks"`
Signed-off-by: Mmadu Manasseh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (2)
- .tool-versions: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
pkg/checks/preupgrade/kubepug.go:54
- The format specifier '%b' converts the index 'i' into its binary representation; if a decimal representation is intended, consider using '%d' instead.
tmpFile := fmt.Sprintf("%s/%b.yaml", tempDir, i)
Signed-off-by: Mmadu Manasseh <[email protected]>
max-concurrenct-checks
->max-concurrent-checks
generated-store
->kubepug-generated-store
golangci-lint run --fix
and also manually fixing other cases.