You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A quick and dirty update that adds V3 support(But keeps v2 support available) since june 1. marks the end of v2 deprication period
You might not want to pull it directly into 2.x as it contains a few breaking changes, and needs a bit of cleanup.
To keep compability working for v2 while migrating to v3:
The RecurringPayments constructor now takes an api_version argument which defaults to 3 - Set this to 2
Namespaces for: RequestCreateAgreement, CampaignRequest, RequestUpdateAgreement and Agreement must be updated from zaporylie\Vipps\Model\RecurringPayment\ to zaporylie\Vipps\Model\RecurringPayment\v2\
Hi there. First of all - it's so awesome you decided to contribute to this project. I really appreciate it.
In fact via this PR you made me aware of the June 1 deadline 🙈 I reached out to Vipps and asked them about the deadline confirmation and turns out the deadline was extended until November 1 which gives us a bit more time to make a clean transition.
I am out for 2 weeks of vacation but will have a look into the proposed PR and how to make it backward-compatible when I'm back. Meanwhile I hope extended deadline will help you with your project - I know it definitely saves me some stress ;)
Hi! Thank you, and i really appreciate the time and work you've put into this library.
It's great news that the deadline has been extended, as June 1 came as quite the shock for us as well..
No hurry with checking out the changes, have a great vacation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick and dirty update that adds V3 support(But keeps v2 support available) since june 1. marks the end of v2 deprication period
You might not want to pull it directly into 2.x as it contains a few breaking changes, and needs a bit of cleanup.
To keep compability working for v2 while migrating to v3:
zaporylie\Vipps\Model\RecurringPayment\tozaporylie\Vipps\Model\RecurringPayment\v2\