Provide example alerts in Cookie scan rules

[martinspielmann]

The CWE id was already managed for these Alerts/ScanRules and within ZAP they were already presented to the user.
However, when visiting the alert detail pages online (https://www.zaproxy.org/docs/alerts/), CWE (and WASC) links were not generated correctly.

The reason is, that the id values were set inline to the alert.
For the script which generates the detail pages however, the getter methods for the ids have to be added publicly to the class.

Note: if this solves the issue, I'll vote for another follow up issue to add this change to the PluginPassiveScanner parent class,
so that the docs will be generated consistently over all Passive Scan Rules.

Fixes zaproxy/zaproxy#6140.

[thc202]

Note: if this solves the issue, I'll vote for another follow up issue to add this change to the PluginPassiveScanner parent class, so that the docs will be generated consistently over all Passive Scan Rules.

It does, but there's a new way to provide the alert data, more details in zaproxy/zaproxy#6119 (this could be changed to do that if you want).

[kingthorin]

To address the DCO requirement you'll need to sign-off the commit(s):

• https://github.com/zaproxy/zaproxy/blob/develop/CONTRIBUTING.md#developer-certificate-of-origin
• https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff

[kingthorin]

Also needs a spotlessApply: ./gradlew :addOns:pscanrules:spotlessApply

[martinspielmann]

Thanks @kingthorin and @thc202 for the hints, sorry saw that too late 🐒 Will update PR asap

[kingthorin]

No worries. Every project/contribution is a new adventure 😀

[martinspielmann]

Regarding the comment:

It does, but there's a new way to provide the alert data, more details in zaproxy/zaproxy#6119 (this could be changed to do that if you want).

After reading through, I think it would indeed be cleaner to go for the new List<Alert> getExampleAlerts() method. Should I add that here already or would it be preferable to have that in another PR clearly referencing to the introduction of getExampleAlerts

[kingthorin]

I'm fine with it being here. You can always squash this.

[martinspielmann]

I'm fine with it being here. You can always squash this.

Ok ready :)

[kingthorin]

One minor thing, and it’s an existing issue

[kingthorin]

Thanks

[thc202]

Thank you!