pscanrules/ascanrules: Example Alerts and Alert Refs #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to tackle something before work today, so this is it 😀 |
|
Will get them spotlessApplied shortly. If someone is able to review anyway that'd be great. |
kingthorin
force-pushed
the
alert-batch1
branch
from
d9bae6f to
5f58a9f
Compare
|
FYI noticed this on one of the recent runs, it's only a warning but might be something to look into: Execution optimizations have been disabled for task ':addOns:ascanrulesBeta:compileJava' to ensure correctness due to the following reasons:
- Gradle detected a problem with the following location: '/home/runner/work/zap-extensions/zap-extensions/addOns/oast/build/classes/java/main'. Reason: Task ':addOns:ascanrulesBeta:compileJava' uses this output of task ':addOns:oast:enhance' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> Task :addOns:ascanrulesBeta:enhance UP-TO-DATE
> Task :addOns:ascanrulesBeta:processResources UP-TO-DATE
> Task :addOns:ascanrulesBeta:classes
> Task :addOns:ascanrulesBeta:compileTestJava
... |
|
That's caused by a 3rd-party plugin. |
thc202
reviewed
Nov 21, 2022
...ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
.../pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/InfoSessionIdUrlScanRule.java
Outdated
Show resolved
Hide resolved
...es/src/test/java/org/zaproxy/zap/extension/ascanrules/DirectoryBrowsingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
alert-batch1
branch
from
5f58a9f to
cd67916
Compare
|
I think I've addressed all those. |
thc202
reviewed
Nov 21, 2022
...ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
...es/src/test/java/org/zaproxy/zap/extension/ascanrules/DirectoryBrowsingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
- CHANGELOGs > Added change notes. - Scan rules > Added example alerts handling. - UnitTests > Added new unit test to assert the example alerts. - InfoSessionIdUrlScanRule > Added alert refs. Removed unused local variable. Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
alert-batch1
branch
from
cd67916 to
476e7fa
Compare
|
Got those too. |
thc202
approved these changes
Nov 21, 2022
|
Thank you! |
psiinon
approved these changes
Nov 22, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to zaproxy/zaproxy#6119 & zaproxy/zaproxy#7100
Signed-off-by: kingthorin [email protected]