pscanrules: PII Scan Rule add Solution, Example Alerts #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
commented
Jan 8, 2023
addOns/commonlib/src/main/java/org/zaproxy/addon/commonlib/binlist/BinRecord.java
Show resolved
Hide resolved
thc202
reviewed
Jan 8, 2023
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/PiiScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
pii-deets
branch
2 times, most recently
from
dd82963 to
e89c712
Compare
kingthorin
changed the title
|
Tweaked. |
thc202
reviewed
Jan 10, 2023
addOns/commonlib/src/main/java/org/zaproxy/addon/commonlib/binlist/BinRecord.java
Outdated
Show resolved
Hide resolved
thc202
reviewed
Jan 10, 2023
|
How is this part of 7676? The commit summary/description still mentions alert refs. There's a typo in |
|
Part of 7676 in that it now displays Evidence correctly. |
commonlib - BinRecord > Expose constructor for testing purposes. - Changelog already has a maint note. pscanrules - CHANGELOG > Added change notes. - PiiScanRule > Added example alert handling, which is also leveraged when raising alerts and includes the new solution text. Also exposes unaltered Evidence. - PiiScanRuleUnitTest > Now asserts the expected example alert, and otherinfo. - Messages.properties > Updated to include a name/value pair for PII Disclosure solution text. Signed-off-by: kingthorin <[email protected]>
|
Tweaked. |
|
OK, I'd say it's related then (I expect "part of" to (partially) address it). |
thc202
approved these changes
Jan 10, 2023
|
Thank you! |
|
That’s fair. I’ve tweaked the PR comment wording 😉 |
psiinon
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commonlib
pscanruls
Related to:
Signed-off-by: kingthorin [email protected]