-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pscanrules: add example alerts to DirectoryBrowsingScanRule #4537
Conversation
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
The commit must be signed off: https://github.com/zaproxy/zap-extensions/pull/4537/checks?check_run_id=12567537294 The changelog should be updated: https://github.com/zaproxy/zap-extensions/blob/main/CONTRIBUTING.md You should run the checks locally (e.g. |
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
...es/src/test/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
...es/src/test/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
…lert 10033) | issue zaproxy#6119 Signed-off-by: giothysham <[email protected]>
Signed-off-by: giothysham <[email protected]>
Signed-off-by: giothysham <[email protected]>
I'm sorry for all the pushes, I was figuring out how to properly sign it, this should be the working code though. Thanks for the help and I hope I wasn’t too much trouble. |
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
No problem. There's always a learning curve, we get it. |
Signed-off-by: giothysham <[email protected]>
General question: If the name is differentiated should we also be implementing AlertRefs? (Not necessarily for this PR, but just to clarify things further for zaproxy/zaproxy#7100) |
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
...pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRule.java
Outdated
Show resolved
Hide resolved
...es/src/test/java/org/zaproxy/zap/extension/pscanrules/DirectoryBrowsingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
I don't think one implies the other, in this case it's exactly the same problem. |
Okay, thanks. |
Signed-off-by: giothysham <[email protected]>
Signed-off-by: giothysham <[email protected]>
Thank you! How would you like to be credited (e.g. name, handle)? |
Giothysham is fine, thanks for adding me into that list :D |
Added:
Moved:
Note: This is my first time contributing as a university student, so thorough examination is advised
Part of zaproxy/zaproxy#6119.