Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pscanrules: add example alerts to DirectoryBrowsingScanRule #4537

Merged
merged 6 commits into from
Apr 10, 2023

Conversation

Giothysham
Copy link
Contributor

@Giothysham Giothysham commented Apr 6, 2023

Added:

  • buildAlert()
  • getExampleAlerts()
  • shouldReturnExpectedExampleAlert() [Test]

Moved:

  • Local variables: server, msg and evidence changed to private static variables
  • newAlert() code into buildAlert()

Note: This is my first time contributing as a university student, so thorough examination is advised

Part of zaproxy/zaproxy#6119.

@thc202 thc202 changed the title List<Alert> getExampleAlerts() added for pscanrules\DirectoryBrowsingScanRule (Alert 10033) | issue #6119 pscanrules: add example alerts to DirectoryBrowsingScanRule Apr 6, 2023
@thc202
Copy link
Member

thc202 commented Apr 6, 2023

The commit must be signed off: https://github.com/zaproxy/zap-extensions/pull/4537/checks?check_run_id=12567537294

The changelog should be updated: https://github.com/zaproxy/zap-extensions/blob/main/CONTRIBUTING.md

You should run the checks locally (e.g. ./gradlew :aO:pscanrules:check).

@Giothysham
Copy link
Contributor Author

I'm sorry for all the pushes, I was figuring out how to properly sign it, this should be the working code though. Thanks for the help and I hope I wasn’t too much trouble.

@kingthorin
Copy link
Member

No problem. There's always a learning curve, we get it.

@kingthorin
Copy link
Member

kingthorin commented Apr 6, 2023

General question: If the name is differentiated should we also be implementing AlertRefs? (Not necessarily for this PR, but just to clarify things further for zaproxy/zaproxy#7100)

@thc202
Copy link
Member

thc202 commented Apr 6, 2023

I don't think one implies the other, in this case it's exactly the same problem.

@kingthorin
Copy link
Member

Okay, thanks.

Signed-off-by: giothysham <[email protected]>
Signed-off-by: giothysham <[email protected]>
@thc202 thc202 merged commit b08198f into zaproxy:main Apr 10, 2023
@thc202
Copy link
Member

thc202 commented Apr 10, 2023

Thank you! How would you like to be credited (e.g. name, handle)?
https://www.zaproxy.org/docs/desktop/credits/#zap-extended-team

@Giothysham
Copy link
Contributor Author

Giothysham is fine, thanks for adding me into that list :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants