Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascanrules: add example alerts to Spring Actuator #5661

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

anaaroch
Copy link
Contributor

@anaaroch anaaroch commented Aug 20, 2024

Overview

Me and Lucas Bergholz worked on this together, with the porpuse of adding the alert for SpringActuatorScanRule. We are open for any feedbacks of our work, as this is our first contribution on this issue.

Related Issues

Part of zaproxy/zaproxy#6119.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Copy link

github-actions bot commented Aug 20, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Copy link

github-actions bot commented Aug 26, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@anaaroch
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@LucasBergholz
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

zapbot added a commit to zaproxy/cla that referenced this pull request Aug 30, 2024
Signed-off-by: Ana Rocha <[email protected]>
Co-authored-by: Lucas Bergholz <[email protected]>
@thc202
Copy link
Member

thc202 commented Sep 16, 2024

Pending review comment addressed and conflict resolved.

@thc202
Copy link
Member

thc202 commented Sep 16, 2024

Thank you @LucasBergholz and @anaaroch!

@kingthorin kingthorin merged commit 3a36b4b into zaproxy:main Sep 16, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants