ascanrules: SQLi PostgreSQL rename scan rule (all time based)#6567
Merged
thc202 merged 1 commit intozaproxy:mainfrom Jul 16, 2025
Merged
ascanrules: SQLi PostgreSQL rename scan rule (all time based)#6567thc202 merged 1 commit intozaproxy:mainfrom
thc202 merged 1 commit intozaproxy:mainfrom
Conversation
Member
|
Great job, no security vulnerabilities found in this Pull Request |
thc202
reviewed
Jul 15, 2025
...src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionPostgreSqlTimingScanRule.java
Outdated
Show resolved
Hide resolved
Member
|
The link to the code in the help page still needs to be updated. |
Member
|
The comments left here apply to other split/rename PRs as well. |
kingthorin
force-pushed
the
sqli-pg-split
branch
3 times, most recently
from
ecddf90 to
3e14748
Compare
Member
Author
|
Done across all (I believe) |
kingthorin
changed the title
thc202
reviewed
Jul 15, 2025
...c/main/javahelp/org/zaproxy/zap/extension/ascanrules/resources/help/contents/ascanrules.html
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
sqli-pg-split
branch
from
3e14748 to
3f14c38
Compare
thc202
approved these changes
Jul 15, 2025
Member
|
Thank you! |
Member
|
The errors map could be removed from this one too (if done in the other scan rule). |
kingthorin
force-pushed
the
sqli-pg-split
branch
from
3f14c38 to
d2a710a
Compare
Member
Author
|
Oh there's probably a bunch like that. I'll double check. This one has been fixed. |
kingthorin
force-pushed
the
sqli-pg-split
branch
from
d2a710a to
ac49e0a
Compare
Member
Author
|
Okay I think I got them across all the rules. |
kingthorin
force-pushed
the
sqli-pg-split
branch
from
ac49e0a to
1160738
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com> # Conflicts: # addOns/ascanrules/CHANGELOG.md # addOns/ascanrules/src/main/resources/org/zaproxy/zap/extension/ascanrules/resources/Messages.properties
kingthorin
force-pushed
the
sqli-pg-split
branch
from
1160738 to
9acdd3b
Compare
psiinon
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The SQL Injection PostgreSQL scan rule has been renamed to indicate that it currently only does time based tests (Issue 7341). (The help already indicates that it is time based).
Related Issues