Skip to content

Conversation

@psiinon
Copy link
Member

@psiinon psiinon commented Oct 24, 2025

Draft while I have a play to see if I can validate the params...

@psiinon psiinon force-pushed the auto/configs branch 2 times, most recently from c75c637 to 671b514 Compare October 24, 2025 13:51
@psiinon psiinon marked this pull request as ready for review October 24, 2025 13:52
@psiinon
Copy link
Member Author

psiinon commented Oct 24, 2025

Logo
Checkmarx One – Scan Summary & Detailse9472c04-b636-43ff-8b5b-44d83d379f1e

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@psiinon
Copy link
Member Author

psiinon commented Oct 24, 2025

This is now ready for review, unfortunately it looks like it will not be possible to sanity check the keys

@kingthorin
Copy link
Member

Looks good, but there's one test that needs attention.

@psiinon
Copy link
Member Author

psiinon commented Oct 24, 2025

Looking into that now. I thought I'd fixed it, but apparently not.
And its a significant test because its checking the ordering is right - if a non ordered Map is used it can fail ...

@psiinon psiinon force-pushed the auto/configs branch 3 times, most recently from 68eb714 to c5995c6 Compare October 24, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants