Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recording deployed component status in package deploy #3556

Merged
merged 9 commits into from
Mar 10, 2025

Conversation

sgettys
Copy link
Contributor

@sgettys sgettys commented Mar 4, 2025

Description

Adds back in deployed component status when deploying a package.
...

Related Issue

Fixes #3553

Checklist before merging

@sgettys sgettys requested review from a team as code owners March 4, 2025 16:43
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit f38c93b
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67cb37ef665d1800076f76f0
😎 Deploy Preview https://deploy-preview-3556--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sgettys sgettys force-pushed the feat/deployed-component-status branch from 06d8f02 to 416086f Compare March 4, 2025 16:45
@sgettys sgettys force-pushed the feat/deployed-component-status branch from 416086f to f935c16 Compare March 4, 2025 16:49
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/deploy.go 0.00% 16 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/types/k8s.go 60.27% <ø> (ø)
src/pkg/cluster/zarf.go 14.76% <0.00%> (-0.07%) ⬇️
src/pkg/packager/deploy.go 5.41% <0.00%> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment to make sure we sure the deploying status is utilized. As discussed synchronously an e2e test would be good here, given the difficultly of adding a unit test in deploy components atm I think it's reasonable to not add any for this change.

Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some thoughts for the test at hand.

Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test, this is close. Run make lint-go to fix the lint errors locally.

@sgettys sgettys requested a review from AustinAbro321 March 10, 2025 15:50
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtkeller brandtkeller added this pull request to the merge queue Mar 10, 2025
Merged via the queue into zarf-dev:main with commit a70c12f Mar 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report component status for each deployed component
3 participants