-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recording deployed component status in package deploy #3556
feat: recording deployed component status in package deploy #3556
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
06d8f02
to
416086f
Compare
Signed-off-by: Steven Gettys <[email protected]>
416086f
to
f935c16
Compare
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment to make sure we sure the deploying status is utilized. As discussed synchronously an e2e test would be good here, given the difficultly of adding a unit test in deploy components atm I think it's reasonable to not add any for this change.
Signed-off-by: Steven Gettys <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some thoughts for the test at hand.
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test, this is close. Run make lint-go
to fix the lint errors locally.
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds back in deployed component status when deploying a package.
...
Related Issue
Fixes #3553
Checklist before merging