Skip to content

fix(wait): properly resolve kind when group conflicts between resources#4628

Merged
brandtkeller merged 3 commits intomainfrom
fix-wait-conflict-group
Feb 20, 2026
Merged

fix(wait): properly resolve kind when group conflicts between resources#4628
brandtkeller merged 3 commits intomainfrom
fix-wait-conflict-group

Conversation

@AustinAbro321
Copy link
Member

@AustinAbro321 AustinAbro321 commented Feb 20, 2026

Description

There is a bug in Zarf where running a wait command with a kind where there exists another kind of that name does not get properly resolved. For instance, zarf tools wait-for gateways.networking.istio.io admin-gateway would not work as it would try to resolve the default from Kubernetes gateway resource.

Versions don't matter in this context as they're considered the same object by Kubernetes, I tested this out with kubectl wait

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit e273286
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6998c6857e4a3b0008c2bc79

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review February 20, 2026 20:32
@AustinAbro321 AustinAbro321 requested review from a team as code owners February 20, 2026 20:32
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandtkeller brandtkeller added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit db3cd9d Feb 20, 2026
30 checks passed
@brandtkeller brandtkeller deleted the fix-wait-conflict-group branch February 20, 2026 22:08
@github-project-automation github-project-automation bot moved this to Done in Zarf Feb 20, 2026
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/wait/wait.go 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/wait/wait.go 11.87% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants