-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the node LSP for the native binaries #7 #384
base: master
Are you sure you want to change the base?
Conversation
language server now expects to be run directly through language-server.js
…if something fails
the configuration supports overriding the default function as get_root_dir fixes zbirenbaum#371
the configuration supports overriding the default function as get_root_dir fixes zbirenbaum#371
Remove node-related code
Awesome work, thank you so much!! My one note is that I think it's pretty important for a project that is supplying prebuilt binaries to do so through an automated update script which pulls down the files directly or performs some setup step through a user command like If you want to go ahead and merge this as just this once feel free to, I see you have a ton of awesome PRs in flight and don't want to make too much extra work for you to get these in. |
Thank for the feedback! It makes complete sense to automate this through an update script for security reasons, I will work on that :P |
No worries. I actually can't seem to download your branch. The binaries are way too huge for Lazy to handle in a timely manner and it looked like it was frozen for a solid minute at 100% resolving delta. I'm going to be firm that this should be done through a separate script which only downloads the binary for your platform |
No problem 🙂 |
Also, quick note, make sure to make them executable after downloading them, had to |
@zbirenbaum I think I got it, the file gymnastics was trickier than I expected but it seems to have fixed another issue at the same time with the WSL authentication. Edit: I am not sure what the conflict is with master 😣, since I even merged master into it minutes ago. |
Since native binaries are now available (here) figured it would be best to use them as it means fewer dependencies (no need for node) and hopefully less overhead so better performance.
I included the binaries as part of the report though I am not sure that is ideal.
But since the LSP was already included I figured it's no different than before except now there are 5 versions.
Hopefully I got the os detection logic right, as I do not have access to most of the architectures to test.
Seems to fix #309 as well!