zfsbootmenu: log errors for unimportable pools #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
force-pushed
the
state-and-madison
branch
from
7ce0462
to
ab5ed75
Compare
zdykstra
commented
Aug 10, 2023
ahesford
reviewed
Sep 8, 2023
zdykstra
force-pushed
the
state-and-madison
branch
2 times, most recently
from
459942c
to
21c9afc
Compare
Before landing at the emergency_shell in the main import loop, log the output of a failed zpool import for every pool that's marked UNAVAIL . In the emergency_shell function, write any log messages at the 'err' level directly to the active console. The 'print_kmsg_logs' helper has been added that accepts a comma-separated list of log levels (as understood by util-linux dmesg). If the feature flags supplied to dmesg fail, fall back to 'dmesg -r' which is understood by both Busybox and util-linux dmesg. Manually convert err,info,... log levels to a numeric code and grep for that at the start of each line.
zdykstra
force-pushed
the
state-and-madison
branch
from
21c9afc
to
695031d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before landing at the emergency_shell in the main import loop, log the output of a failed zpool import for every pool that's marked UNAVAIL .
In the emergency_shell function, write any log messages at the 'err' level directly to the active console.
https://asciinema.org/a/5QLE1dKHyeMDdmGQNmjM29yU0