zfsbootmenu-core: conditionally disable spl_hostid warnings #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
force-pushed
the
verbal-morality-statute
branch
from
fb5b7b9
to
735373b
Compare
ahesford
reviewed
Sep 13, 2023
The default behavior of hostid matching is useful to have on in binary releases. However, it generates a warning message that isn't really relevant for users of that build. It's expected that the spl_hostid value in ZFSBootMenu.EFI won't match the local pool hostid - advising these users to manually set `spl_hostid` on the ZBM KCL runs counter to how we recommend ZBM should be used.
zdykstra
force-pushed
the
verbal-morality-statute
branch
from
735373b
to
ce8e6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of hostid matching is useful to have on in binary releases. However, it generates a warning message that isn't really relevant for users of that build.
It's expected that the spl_hostid value in ZFSBootMenu.EFI won't match the local pool hostid - advising these users to manually set
spl_hostidon the ZBM KCL runs counter to how we recommend ZBM should be used.