Closed
Conversation
668b109 to
c237ec9
Compare
Member
|
Before this is vendored, I'd like to check kernel configs for Debian, Arch and maybe Gentoo to confirm that they have the right EFI handoff option enabled. If they don't, this won't get us very far. |
c237ec9 to
7b35045
Compare
Member
|
Arch's 6.3.x kernel ships with |
Member
Author
|
Because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to update
generate-zbmto point to the vendored location before looking for gummiboot or systemd-boot versions, but I'm thinking we should actually look in seven places for the vendored file:That covers common cases like running
generate-zbmdirectly from the repo, running it in some installed prefix and (maybe) running in our build container. (This needs to be tested.) I'm looking for some suggestions on this search.Once we have the desired behavior, we should stop installing
gummiboot-efistubin the build container.