Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor the Gummiboot UEFI stub loader #506

Closed
wants to merge 1 commit into from
Closed

Conversation

ahesford
Copy link
Member

We need to update generate-zbm to point to the vendored location before looking for gummiboot or systemd-boot versions, but I'm thinking we should actually look in seven places for the vendored file:

./zfsbootmenu/stub
../zfsbootmenu/stub
../share/zfsbootmenu/stub
dirname(__FILE__)/zfsbootmenu/stub
dirname(__FILE__)/../zfsbootmenu/stub
dirname(__FILE__)/../share/zfsbootmenu/stub
/usr/share/zfsbootmenu/stub

That covers common cases like running generate-zbm directly from the repo, running it in some installed prefix and (maybe) running in our build container. (This needs to be tested.) I'm looking for some suggestions on this search.

Once we have the desired behavior, we should stop installing gummiboot-efistub in the build container.

@zdykstra
Copy link
Member

Before this is vendored, I'd like to check kernel configs for Debian, Arch and maybe Gentoo to confirm that they have the right EFI handoff option enabled. If they don't, this won't get us very far.

@zdykstra
Copy link
Member

Arch's 6.3.x kernel ships with CONFIG_EFI_HANDOVER_PROTOCOL enabled. Ubuntu 23.10's 6.5.x kernel ships with it enabled.

@ahesford
Copy link
Member Author

Because generate-zbm is now more intelligent about writing EFI bundles, this is less relevant.

@ahesford ahesford closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants